> On April 19, 2015, 8:55 p.m., Ali Saidi wrote: > > src/arch/arm/ArmSystem.py, line 94 > > <http://reviews.gem5.org/r/2741/diff/1/?file=44484#file44484line94> > > > > Could you create a new intermediate class for both FreeBSD and Linux? > > Right now this is all duplicated and I'd really prefer to not have the > > duplication > > Ruslan Bukin wrote: > python is easy, but it involves some mess in C++. Not sure how to do that
I have added GenericArmSystem. thanks - Ruslan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2741/#review6056 ----------------------------------------------------------- On April 23, 2015, 3:04 p.m., Ruslan Bukin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2741/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 3:04 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This adds support for FreeBSD/aarch64 FS and SE mode (basic set of syscalls > only) > > > Diffs > ----- > > src/sim/process.cc ea6308d > src/base/vnc/vncserver.cc 77a4316 > src/dev/arm/gic_pl390.cc ced2464 > src/dev/terminal.cc 8950697 > src/kern/SConscript 8fe602b > src/kern/freebsd/events.hh PRE-CREATION > src/kern/freebsd/events.cc PRE-CREATION > src/kern/freebsd/freebsd.hh PRE-CREATION > src/arch/generic/freebsd/threadinfo.hh PRE-CREATION > src/base/loader/elf_object.cc 4abf0a4 > src/base/loader/object_file.hh 09cde5b > src/base/output.cc da9a551 > src/arch/arm/process.cc a08e6ee > src/arch/arm/system.hh f906dc2 > src/arch/arm/system.cc 398aa40 > src/arch/arm/linux/system.hh 4ce6ac4 > src/arch/arm/linux/system.cc e9586f1 > src/arch/arm/freebsd/system.hh PRE-CREATION > src/arch/arm/freebsd/system.cc PRE-CREATION > src/arch/arm/ArmSystem.py ec9d8c8 > src/arch/arm/SConscript a4740a9 > src/arch/arm/freebsd/freebsd.hh PRE-CREATION > src/arch/arm/freebsd/freebsd.cc PRE-CREATION > src/arch/arm/freebsd/process.hh PRE-CREATION > src/arch/arm/freebsd/process.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2741/diff/ > > > Testing > ------- > > Tested on FreeBSD/amd64 host simulating FreeBSD/aarch64 (FS, SE) and > Linux/aarch64 (FS) > > > Thanks, > > Ruslan Bukin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
