----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2749/#review6088 -----------------------------------------------------------
Responding to Nilay's comments over email: I think it would be best if you explained the initial bug that led to this patch. Going forward, the tester will need to work with protocols that do not expect simply a number of CPUs. There will be controllers that only generate instruction fetches, and other controllers that support shared i-caches and separate d-caches. In these protocols, understanding the number of CPUs is not good enough. The tester will need to be more flexible handling ports. - Brad Beckmann On April 27, 2015, 7:23 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2749/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 7:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10811:b826d3a54c0c > --------------------------- > cpu: testers: rubytest: fix the test > > The test was broken. When run with more than a cpu, it resulted in error > while > configuring the system. Coherence protocols assume that multiple cpus are > present when options.num_cpus > 1. But the test only creates one tester even > when we were testing a multicpu system. Now, we will create individual > testers > for each cpu. > > > Diffs > ----- > > src/cpu/testers/rubytest/RubyTester.hh df2aa91dba5b > src/cpu/testers/rubytest/RubyTester.cc df2aa91dba5b > src/cpu/testers/rubytest/RubyTester.py df2aa91dba5b > tests/configs/rubytest-ruby.py df2aa91dba5b > configs/example/ruby_random_test.py df2aa91dba5b > src/cpu/testers/rubytest/Check.hh df2aa91dba5b > src/cpu/testers/rubytest/Check.cc df2aa91dba5b > src/cpu/testers/rubytest/CheckTable.hh df2aa91dba5b > src/cpu/testers/rubytest/CheckTable.cc df2aa91dba5b > > Diff: http://reviews.gem5.org/r/2749/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
