----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2773/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10832:ba670c48f3c8 --------------------------- ruby: slicc: Dynamically find+declare all MachineTypes To avoid statically declaring MachineTypes that can be used by Ruby protocols, modify the SLICC parser to dynamically collect the different machine types from all the available protocols to declare them in the MachineTypes generated enum. This change declares the full set of types, but only generates the controller files for the specified protocol. Diffs ----- src/mem/protocol/SConscript fbdaa08aaa42 src/mem/slicc/ast/DeclAST.py fbdaa08aaa42 src/mem/slicc/ast/DeclListAST.py fbdaa08aaa42 src/mem/slicc/ast/MachineAST.py fbdaa08aaa42 src/mem/slicc/parser.py fbdaa08aaa42 Diff: http://reviews.gem5.org/r/2773/diff/ Testing ------- Built MI_example and MOESI_hammer in gem5. Also applied a personal patch that adds MachineType-dependent code to RubyMemoryController, and successfully built a protocol that does not define machines required by that that code. Benchmarks run in each build, and MachineType-specific functionality appears correct. Thanks, Joel Hestness _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
