----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2803/#review6148 -----------------------------------------------------------
Since this is just the copy of the allocate() function - 1 statement, I would suggest that we extract the common code as much as possible to a common function. - Nilay Vaish On May 11, 2015, 10:23 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2803/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10860:9b5e6bf24743 > --------------------------- > ruby: allocate a block in CacheMemory without updating LRU state > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Types.sm > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2803/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
