> On May 12, 2015, 4:39 a.m., Nilay Vaish wrote: > > Since this is just the copy of the allocate() function - 1 statement, I > > would > > suggest that we extract the common code as much as possible to a common > > function.
Extracted the common code to a common funciton.. Hope it looks better now... - Sooraj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2803/#review6148 ----------------------------------------------------------- On May 26, 2015, 9:03 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2803/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 9:03 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10835:631472483bc8 > --------------------------- > ruby: allocate a block in CacheMemory without updating LRU state > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Types.sm > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/structures/CacheMemory.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/structures/CacheMemory.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2803/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
