----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2824/#review6161 -----------------------------------------------------------
src/mem/ruby/structures/AbstractReplacementPolicy.hh (line 55) <http://reviews.gem5.org/r/2824/#comment5354> The tabs for these two lines aren't the correct width. src/mem/ruby/structures/AbstractReplacementPolicy.hh (line 56) <http://reviews.gem5.org/r/2824/#comment5355> Couple things here: 1) This member variable should not be public, but should be moved into the protected code section 2) There isn't any precedent for using "class" in function or member declarations in gem5. I'd recommend forward declaring class CacheMemory at the beginning of the file to be consistent with other gem5 code that needs to avoid circular header includes. Then, remove "class" from these two lines. src/mem/ruby/structures/CacheMemory.hh (line 100) <http://reviews.gem5.org/r/2824/#comment5352> Function parameters are lower_underscore format throughout this file. This affects these two lines, as well as the function declarations in the other two files. src/mem/ruby/structures/CacheMemory.cc (line 618) <http://reviews.gem5.org/r/2824/#comment5353> Curly braces should be used consistently with the rest of the file. - Joel Hestness On May 11, 2015, 10:21 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2824/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10868:3a95065b2aaf > --------------------------- > ruby: expose access premission to replacement policies > > This patch adds support that allows the replacement policy to identify each > cache block's access permission. This information can be useful when making > replacement decisions. > > > Diffs > ----- > > src/mem/ruby/structures/AbstractReplacementPolicy.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2824/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
