> On May 27, 2015, 9:19 a.m., Joel Hestness wrote: > > src/mem/ruby/structures/AbstractReplacementPolicy.hh, line 58 > > <http://reviews.gem5.org/r/2824/diff/2/?file=45490#file45490line58> > > > > Should this pointer should be private? The replacement policy's parent > > class will have a pointer to the same cache, so it need not be able to > > publicly access the pointer in the replacement policy.
It was made protected, but it can't be private. > On May 27, 2015, 9:19 a.m., Joel Hestness wrote: > > src/mem/ruby/structures/AbstractReplacementPolicy.hh, line 57 > > <http://reviews.gem5.org/r/2824/diff/2/?file=45490#file45490line57> > > > > Can you please use consistent spacing around curly braces (see two > > lines above this)? Fixed. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2824/#review6400 ----------------------------------------------------------- On May 26, 2015, 1:06 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2824/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 1:06 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10839:d3f20078bf20 > --------------------------- > ruby: expose access permission to replacement policies > > This patch adds support that allows the replacement policy to identify each > cache block's access permission. This information can be useful when making > replacement decisions. > > > Diffs > ----- > > src/mem/ruby/structures/AbstractReplacementPolicy.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/structures/CacheMemory.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/structures/CacheMemory.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2824/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
