----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2791/#review6197 -----------------------------------------------------------
It seems we can have a table that maps an operator to the expected type. The code for checking and raising error need not be duplicated. - Nilay Vaish On May 11, 2015, 10:22 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2791/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10848:39b6754a751c > --------------------------- > slicc: improve support for prefix operations > > This patch fixes the type handling when prefix operations are used. > Previously > prefix operators would assume a void return type, which made it impossible to > combine prefix operations with other expressions. This patch allows SLICC > programmers to use prefix operations more naturally. > > > Diffs > ----- > > src/mem/slicc/ast/OperatorExprAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2791/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
