> On May 12, 2015, 3:48 a.m., Nilay Vaish wrote: > > This patch is incorrect on a couple of counts. We are not in 32-bit world. > > Secondly, you should expose the getAddress() function as we expose > > functions related to other classes.
This comment is dissappointing and unprofessional. I'm well aware of address sizes supported in modern systems. Also I would like to point out this patch adds back in a function verbatim that was previously removed. I'm not introducing something new here. As the description specifies, this funciton is used to convert an address offset to an integer, not a 64-bit address. An integer is needed because that is required to create a NodeID. Also there are plenty of uses of 32-bit integers in this file and across gem5. I do not think anyone has expectations to instantiate more than 2 B ruby controllers. Finally what is the benefit of exposing the getAddress function and doing the casting within SLICC? It is not how these sorts of conversions have been handled in the past. There doesn't seem to be any real benefit other than adding more work for us. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2779/#review6132 ----------------------------------------------------------- On May 11, 2015, 10:18 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2779/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:18 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10836:639151f54640 > --------------------------- > ruby: re-added the addressToInt slicc interface function > > This helper function is very useful converting address offsets to integers > that can be used for protocol specific destination mapping. > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Util.sm fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/slicc_interface/RubySlicc_Util.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2779/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
