----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2779/#review6369 -----------------------------------------------------------
Ship it! Assuming you add the assert in the comment above, it looks good to me. - Jason Power On May 11, 2015, 10:18 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2779/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:18 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10836:639151f54640 > --------------------------- > ruby: re-added the addressToInt slicc interface function > > This helper function is very useful converting address offsets to integers > that can be used for protocol specific destination mapping. > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Util.sm fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/slicc_interface/RubySlicc_Util.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2779/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
