> On May 12, 2015, 4:25 a.m., Nilay Vaish wrote: > > src/mem/slicc/ast/VarExprAST.py, line 40 > > <http://reviews.gem5.org/r/2800/diff/1/?file=45043#file45043line40> > > > > Is the function 4 lines below not enough?
Thats a good question. After some investigation, I've determined that since the name() function is a property function, it returns a read only variable that cannot be converted to a string. I believe the actual VarExtAST.name() will generate an error whenever it is called, so we should probably just remove it. Perhaps someone who is more familary with python @property can confirm. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2800/#review6143 ----------------------------------------------------------- On May 11, 2015, 10:20 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2800/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10857:cde98a38fced > --------------------------- > slicc: support for arbitrary DPRINTF flags (not just RubySlicc) > > This patch allows DPRINTFs to be used in SLICC state machines similar to how > they are used by the rest of gem5. Previously all DPRINTFs in the .sm files > had to use the RubySlicc flag. > > > Diffs > ----- > > src/mem/slicc/ast/FuncCallExprAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/VarExprAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/symbols/StateMachine.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2800/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
