> On May 20, 2015, 7:12 a.m., Jason Power wrote: > > src/mem/slicc/symbols/StateMachine.py, line 92 > > <http://reviews.gem5.org/r/2800/diff/3/?file=45151#file45151line92> > > > > Do you need this to be explicitly added? Shouldn't is automatically be > > added when someone uses a DPRINTF with this flag? > > > > I see why RubyGenerated needs to be here, but I don't believe any > > generated code uses RubySlicc (with a cursory grep).
You're right. Fixed. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2800/#review6368 ----------------------------------------------------------- On May 14, 2015, 5:23 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2800/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 5:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10832:cddb1f164072 > --------------------------- > slicc: support for arbitrary DPRINTF flags (not just RubySlicc) > > This patch allows DPRINTFs to be used in SLICC state machines similar to how > they are used by the rest of gem5. Previously all DPRINTFs in the .sm files > had to use the RubySlicc flag. > > > Diffs > ----- > > src/mem/slicc/ast/FuncCallExprAST.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/symbols/StateMachine.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2800/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
