> On May 12, 2015, 3:50 a.m., Nilay Vaish wrote:
> > Why do we need this special case?
>
> Shuai Che wrote:
> This case is used to get the application current running path.
If I have read the patch correctly, the behaviour now will be that
current working directory is returned as a repsonse to
readlink("/proc/self/exe"). I might be running gem5 from any directory.
How do you know this is the path the application wants to know?
a. Can you be more explicit on why you think this is the right behaviour?
b. Assuming this is the behavior we want, should we not append the
executable's name as well?
- Nilay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2778/#review6133
-----------------------------------------------------------
On May 11, 2015, 10:18 p.m., Tony Gutierrez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2778/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:18 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Changeset 10835:14e31dee1390
> ---------------------------
> syscall: Add readlink to x86 with special case /proc/self/exe
>
> This patch implements the correct behavior.
>
>
> Diffs
> -----
>
> src/arch/x86/linux/process.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec
> src/sim/syscall_emul.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec
>
> Diff: http://reviews.gem5.org/r/2778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Gutierrez
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
