> On May 11, 2015, 8:50 p.m., Nilay Vaish wrote:
> > Why do we need this special case?
>
> Shuai Che wrote:
> This case is used to get the application current running path.
>
> Nilay Vaish wrote:
> If I have read the patch correctly, the behaviour now will be that
> current working directory is returned as a repsonse to
> readlink("/proc/self/exe"). I might be running gem5 from any directory.
> How do you know this is the path the application wants to know?
>
> a. Can you be more explicit on why you think this is the right behaviour?
> b. Assuming this is the behavior we want, should we not append the
> executable's name as well?
Fixed
- Tony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2778/#review6133
-----------------------------------------------------------
On May 21, 2015, 1:41 p.m., Tony Gutierrez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2778/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 1:41 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Changeset 10838:76fcde446236
> ---------------------------
> syscall_emul: Add readlink to with special case /proc/self/exe
>
> when reading from /proc/self/exe readlink will return the path where the
> gem5 binary is. this patch fixes this, allowing binaries to read their own
> path.
>
>
> Diffs
> -----
>
> src/arch/x86/linux/process.cc ecbab252275728bc4dfd93631e0edaecf39b8d95
> src/sim/syscall_emul.cc ecbab252275728bc4dfd93631e0edaecf39b8d95
>
> Diff: http://reviews.gem5.org/r/2778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tony Gutierrez
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
