> On May 19, 2015, 10:45 p.m., Alexandru Dutu wrote: > > src/cpu/kvm/vm.hh, line 265 > > <http://reviews.gem5.org/r/2837/diff/1/?file=45334#file45334line265> > > > > Should this go in a different file?
Yes, it probably should. I'll fix that before committing. Do you want me to repost the patch? On May 19, 2015, 10:45 p.m., Andreas Sandberg wrote: > > Just curious what is the usage scenario for this, it seems that it can be > > used to interrupt the VM even if there is no physical interrupt. The usage scenario for this is cases where we can't use the IO-mapped timer and have to rely on the kernel doing register-mapped timer emulation (we can't intercept timer control registers in gem5). At the moment, that means that we also rely on the kernel emulating the interrupt controller. This exeuction mode is typically useful for userspace bringup with a kernel that doesn't support memory-mapped timers (a lot of old kernel have issues with these). - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2837/#review6351 ----------------------------------------------------------- On May 18, 2015, 1:29 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2837/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 1:29 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10849:d59f9d2d90f7 > --------------------------- > kvm, arm, dev: Add an in-kernel GIC implementation > > This changeset adds a GIC implementation that uses the kernel's > built-in support for simulating the interrupt controller. Since there > is currently no support for state transfer between gem5 and the > kernel, the device model does not support serialization and CPU > switching (which would require switching to a gem5-simulated GIC). > > > Diffs > ----- > > src/arch/arm/kvm/KvmGic.py PRE-CREATION > src/arch/arm/kvm/SConscript PRE-CREATION > src/arch/arm/kvm/gic.hh PRE-CREATION > src/arch/arm/kvm/gic.cc PRE-CREATION > src/cpu/kvm/vm.hh 9b424e7adac5 > src/cpu/kvm/vm.cc 9b424e7adac5 > > Diff: http://reviews.gem5.org/r/2837/diff/ > > > Testing > ------- > > Tested with the gem5's aarch64 kvm implementation (see separate review > request). Boots Linux and interacts nicely with the interactive console. > Note: The kernel requires simulated devices to be well behaved and clear > interrupts. This means that the PCI IDE device model doesn't work. Use the > VirtIO block device instead. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
