> On May 11, 2015, 11:48 p.m., Nilay Vaish wrote: > > Please the read the discussion we had for this patch before: > > http://reviews.gem5.org/r/1620/. I still think this is a bad idea. > > Brad Beckmann wrote: > I don't quite understand your resistence. This patch only provides more > flexibility in naming. It won't allow two variables with the same id.
On 5/13 Nilay said "The flexibility is not required. We all have written lots of code in several different languages where this flexibility does not exist. I am against adding things to a language that are not required. I will say the same thing that I said in a different mail: if my code is broken, I would not try to fix the compiler." The code that uses this functionality is not broken. This feature does not break any existing code. It only helps the programmer. The benefits certainly outweigh any costs, which appears to be rather minimal. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2775/#review6129 ----------------------------------------------------------- On May 11, 2015, 10:17 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2775/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:17 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10832:c3db4307f5e4 > --------------------------- > slicc: isinstance bugfix > > This fix prevents spurious errors when searching for a symbol that may be > located in one of multiple symbol tables. > > > Diffs > ----- > > src/mem/slicc/symbols/SymbolTable.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2775/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
