> On May 29, 2015, 4:25 p.m., Joel Hestness wrote: > > I'm confused about the commit message: Based on the handling of the > > freeList and evictions, it seems like the only limit on TLB entries per > > thread is the total TLB size, so there isn't a statically set number of > > entries per thread. Am I missing something? If not, can you please fix the > > commit message?
Actually the commit message has not got updated to reflect the changes in the code. Thanks for pointing this! - Alexandru ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2852/#review6433 ----------------------------------------------------------- On May 28, 2015, 3:38 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2852/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 3:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10860:f4565ce598dd > --------------------------- > x86, o3: Enabling x86 TLBs for multiple hardware threads > This patch extends the x86 TLB to be shared among multiple hardware threads. > Its size will represent the number of all TLB entries that can be allocated to > all threads, therefore there is statically assigned number of entries per > thread. > > > Diffs > ----- > > src/arch/x86/tlb.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/arch/x86/tlb.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/cpu.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > src/arch/generic/tlb.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/arch/x86/isa.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > src/arch/x86/pagetable.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/arch/x86/pagetable.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > src/arch/x86/pagetable_walker.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2852/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
