----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2869/#review6506 -----------------------------------------------------------
src/dev/arm/gpu_nomali.hh (line 40) <http://reviews.gem5.org/r/2869/#comment5583> _HH_ src/dev/arm/gpu_nomali.hh (line 79) <http://reviews.gem5.org/r/2869/#comment5584> bool set. src/dev/arm/gpu_nomali.hh (line 123) <http://reviews.gem5.org/r/2869/#comment5585> Since we are in file that is for nomali, I would like to call this variable just info. src/dev/arm/gpu_nomali.hh (line 126) <http://reviews.gem5.org/r/2869/#comment5586> Maybe rename the variable to handle or libHandle or something similar. src/dev/arm/gpu_nomali.cc (line 146) <http://reviews.gem5.org/r/2869/#comment5587> This will never evaluate to true since size == 4 here. src/dev/arm/gpu_nomali.cc (line 167) <http://reviews.gem5.org/r/2869/#comment5588> Same comment as above. - Nilay Vaish On June 8, 2015, 11:14 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2869/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 11:14 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10869:2222689a52b3 > --------------------------- > dev, arm: Add a device model that uses the NoMali model > > Add a simple device shim that interfaces with the NoMali model > library. The gem5 side of the interface supports Mali T60x/T62x/T760 > GPUs. This device model pretends to be a Mali GPU, but doesn't render > anything and executes in zero time. > > > Diffs > ----- > > src/dev/arm/NoMali.py PRE-CREATION > src/dev/arm/SConscript 282c2a89ace8 > src/dev/arm/gpu_nomali.hh PRE-CREATION > src/dev/arm/gpu_nomali.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2869/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
