> On June 19, 2015, 3:03 p.m., Nilay Vaish wrote: > > src/dev/arm/gpu_nomali.hh, line 79 > > <http://reviews.gem5.org/r/2869/diff/1/?file=46040#file46040line79> > > > > bool set.
This can't be changed to set since this signature is defined in the NoMali C library. > On June 19, 2015, 3:03 p.m., Nilay Vaish wrote: > > src/dev/arm/gpu_nomali.cc, line 146 > > <http://reviews.gem5.org/r/2869/diff/1/?file=46041#file46041line146> > > > > This will never evaluate to true since size == 4 here. Thanks! That was supposed to be addr (i.e., check that addr is 4-byte aligned) and not size. > On June 19, 2015, 3:03 p.m., Nilay Vaish wrote: > > src/dev/arm/gpu_nomali.hh, line 123 > > <http://reviews.gem5.org/r/2869/diff/1/?file=46040#file46040line123> > > > > Since we are in file that is for nomali, I would like to call this > > variable just info. I'd prefer not to do that since that would be a pretty generic name that could easily alias with global functions. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2869/#review6506 ----------------------------------------------------------- On June 8, 2015, 12:14 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2869/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 12:14 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10869:2222689a52b3 > --------------------------- > dev, arm: Add a device model that uses the NoMali model > > Add a simple device shim that interfaces with the NoMali model > library. The gem5 side of the interface supports Mali T60x/T62x/T760 > GPUs. This device model pretends to be a Mali GPU, but doesn't render > anything and executes in zero time. > > > Diffs > ----- > > src/dev/arm/NoMali.py PRE-CREATION > src/dev/arm/SConscript 282c2a89ace8 > src/dev/arm/gpu_nomali.hh PRE-CREATION > src/dev/arm/gpu_nomali.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2869/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
