> On June 19, 2015, 3:29 p.m., Joel Hestness wrote:
> > Can you please expand on the commit message? I understand that these
> > changes are to allow multiple RubySystem instances, but some detailed
> > information about this should be available in the commit log.
Hello Joel,
Thanks for pointing that out. Is the following sufficient?
ruby: replace global cycle counter w/ cycle per ruby system
This patch begins the process of removing global variables from the Ruby
source with the goal to eventually allowing users to invoke multiple Ruby
instances in a single simulation. Currently, users cannot do so because
several global variables and static members are referenced by the Ruby
System
object in a way that assumes that there will only ever be a single Ruby
System. These need to be replaced with per Ruby System equivalents.
- Brandon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2901/#review6522
-----------------------------------------------------------
On June 22, 2015, 4:36 p.m., Brandon Potter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2901/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 4:36 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Changeset 10876:8f73cf051cdd
> ---------------------------
> ruby: replace global cycle counter w/ cycle per ruby system
>
>
> Diffs
> -----
>
> src/mem/ruby/network/Network.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/network/simple/Switch.cc
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/network/simple/Throttle.hh
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/network/simple/Throttle.cc
> ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/system/System.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/system/System.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/common/Global.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
> src/mem/ruby/common/Global.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18
>
> Diff: http://reviews.gem5.org/r/2901/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brandon Potter
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
