> On June 23, 2015, 3:38 p.m., Joel Hestness wrote: > > src/mem/ruby/network/simple/Throttle.hh, line 55 > > <http://reviews.gem5.org/r/2901/diff/2/?file=46726#file46726line55> > > > > I don't understand why this is inconsistent with the GarnetNetwork > > changes: Here, you've added a per-instance pointer to Ruby to achieve the > > same functionality as with the GarnetNetwork changes, but in the > > GarnetNetwork, you're accessing the RubySystem from the params() in > > collateStats. > > > > I'd rather these be consistent. > > > > NOTE: If you were to follow my overall suggestion of making the > > start_time static in RubySystem, this change would not need to happen, and > > there would be no consistency issues between here and the GarnetNetwork.
Throttle is not derived from a clocked memory object, but it does have a clocked memory object that is passed into it. Is it reasonable to assume that this clocked memory object will return the same cycle count as the RubySystem object? If so, I think that it would be possible to avoid passing in the pointer to RubySystem. If not, the RubySystem pointer needs to be passed in to give the right cycle count with curCycle inside Throttle::collateStats(). - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2901/#review6573 ----------------------------------------------------------- On June 22, 2015, 4:36 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2901/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 4:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10876:8f73cf051cdd > --------------------------- > ruby: replace global cycle counter w/ cycle per ruby system > > > Diffs > ----- > > src/mem/ruby/network/Network.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/simple/Switch.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/simple/Throttle.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/simple/Throttle.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/system/System.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/system/System.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/common/Global.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/common/Global.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > > Diff: http://reviews.gem5.org/r/2901/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
