> On June 21, 2015, 6:18 a.m., Nilay Vaish wrote: > > src/cpu/o3/cpu.cc, line 741 > > <http://reviews.gem5.org/r/2856/diff/1/?file=45659#file45659line741> > > > > Why do we have different names for the functions called on Fetch and > > Commit stages?
For the fetch stage there already was a function which was handleing status update, however just for thread 0. So that function needed to be updated and I kept the name. For commit there is no notion of a quiesce state, so I chose a different name that makes sense for this stage. - Alexandru ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2856/#review6536 ----------------------------------------------------------- On May 28, 2015, 3:40 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2856/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 3:40 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10862:c32578991199 > --------------------------- > cpu: o3: Commit stage updates for hw threads priority list > This patch makes sure the priority_list in the fetch stage is kept in sync > with suspendContext and activateContext calls. > > > Diffs > ----- > > src/cpu/o3/commit.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/commit_impl.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/cpu.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2856/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
