> On June 22, 2015, 2:35 p.m., Jason Power wrote: > > LGTM. > > > > As an aside, since this is yet another patch that requires blanket changes > > to all slicc protocols, maybe we should require the patch submitter to > > include a script to update the other slicc protocols similar to how we have > > a checkpoint upgrader. Thoughts?
We can. In this particular, just run a sed command: sed -i 's/NetworkMessage/Message/' *.sm. That should be enough. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2905/#review6545 ----------------------------------------------------------- On June 19, 2015, 7:42 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2905/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 7:42 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10884:ac028a40f44a > --------------------------- > ruby: drop NetworkMessage class > > This patch drops the NetworkMessage class. The relevant data members and > functions > have been moved to the Message class, which was the parent of NetworkMessage. > > This is just one patch in a series aimed towards combining different Message > classes > defined across protocols in Ruby. These different classes mostly contain the > same > code and are typically duplicated when a new protocol is written. > > > Diffs > ----- > > src/mem/protocol/MESI_Two_Level-msg.sm ebb3d0737aa7 > src/mem/protocol/MI_example-msg.sm ebb3d0737aa7 > src/mem/protocol/MOESI_CMP_directory-msg.sm ebb3d0737aa7 > src/mem/protocol/MOESI_CMP_token-msg.sm ebb3d0737aa7 > src/mem/protocol/MOESI_hammer-msg.sm ebb3d0737aa7 > src/mem/protocol/Network_test-msg.sm ebb3d0737aa7 > src/mem/protocol/RubySlicc_Exports.sm ebb3d0737aa7 > src/mem/ruby/SConscript ebb3d0737aa7 > src/mem/ruby/common/NetDest.hh ebb3d0737aa7 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.hh > ebb3d0737aa7 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > ebb3d0737aa7 > src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc ebb3d0737aa7 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.hh > ebb3d0737aa7 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > ebb3d0737aa7 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc ebb3d0737aa7 > src/mem/ruby/network/simple/PerfectSwitch.cc ebb3d0737aa7 > src/mem/ruby/network/simple/Throttle.cc ebb3d0737aa7 > src/mem/ruby/slicc_interface/Message.hh ebb3d0737aa7 > src/mem/ruby/slicc_interface/NetworkMessage.hh ebb3d0737aa7 > src/mem/ruby/structures/RubyMemoryControl.cc ebb3d0737aa7 > src/mem/slicc/ast/AssignStatementAST.py ebb3d0737aa7 > src/mem/slicc/symbols/Type.py ebb3d0737aa7 > > Diff: http://reviews.gem5.org/r/2905/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
