On Mon, 22 Jun 2015, Jason Power wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2905/#review6545
-----------------------------------------------------------
Ship it!
LGTM.
As an aside, since this is yet another patch that requires blanket
changes to all slicc protocols, maybe we should require the patch
submitter to include a script to update the other slicc protocols
similar to how we have a checkpoint upgrader. Thoughts?
In this particular case, I think a single sed command should work for
everyone. But, say for the patch on renaming Addr to addr, I had to write
2 or 3 different search and replace commands, and even after that some
cases got left out. And I think we would need to understand the grammar
to correctly update all the occurrences. So, while writing a script for
updating SLICC code seems possible, it is harder than doing so for
checkpoints as the grammar for SLICC seems significantly more complex.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
