----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2886/#review6636 -----------------------------------------------------------
Overall I am fine. I would probably read the patch again after your response to questions below and mark it to be shipped. src/mem/cache/cache_impl.hh (lines 182 - 188) <http://reviews.gem5.org/r/2886/#comment5733> What's going on over here that's related to the aim of the patch? src/mem/cache/cache_impl.hh (line 2138) <http://reviews.gem5.org/r/2886/#comment5734> Same question as previous one? - Nilay Vaish On June 10, 2015, 7:59 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2886/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 7:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10877:5715b110f655 > --------------------------- > mem: Remove redundant is_top_level cache parameter > > This patch takes the final step in removing the is_top_level parameter > from the cache. With the recent changes to read requests and write > invalidations, the parameter is no longer needed, and consequently > removed. > > This also means that asymmetric cache hierarchies are now fully > supported (and we are actually using them already with L1 caches, but > no table-walker caches, connected to a shared L2). > > > Diffs > ----- > > configs/common/Caches.py ebb3d0737aa7 > configs/common/O3_ARM_v7a.py ebb3d0737aa7 > configs/example/memcheck.py ebb3d0737aa7 > configs/example/memtest.py ebb3d0737aa7 > src/mem/cache/BaseCache.py ebb3d0737aa7 > src/mem/cache/base.hh ebb3d0737aa7 > src/mem/cache/base.cc ebb3d0737aa7 > src/mem/cache/cache_impl.hh ebb3d0737aa7 > > Diff: http://reviews.gem5.org/r/2886/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
