> On July 1, 2015, 1:39 a.m., Steve Reinhardt wrote:
> > I like the idea of adding a FromCache attribute in packet.cc; my concern 
> > with the current setup is that, if someone added a new cache command, there 
> > wouldn't be anything to indicate to them that they should be adding another 
> > condition to this compound if.
> > 
> > Other than that, looks good!

Sure. Is it ok if we add this as a second patch? I feel like that is a big 
enough change that it deserves a separate changeset.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2886/#review6649
-----------------------------------------------------------


On June 29, 2015, 9:43 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2886/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 9:43 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10887:9be908d7c501
> ---------------------------
> mem: Remove redundant is_top_level cache parameter
> 
> This patch takes the final step in removing the is_top_level parameter
> from the cache. With the recent changes to read requests and write
> invalidations, the parameter is no longer needed, and consequently
> removed.
> 
> This also means that asymmetric cache hierarchies are now fully
> supported (and we are actually using them already with L1 caches, but
> no table-walker caches, connected to a shared L2).
> 
> 
> Diffs
> -----
> 
>   configs/common/Caches.py 73d4798871a5 
>   configs/common/O3_ARM_v7a.py 73d4798871a5 
>   configs/example/memcheck.py 73d4798871a5 
>   configs/example/memtest.py 73d4798871a5 
>   src/mem/cache/BaseCache.py 73d4798871a5 
>   src/mem/cache/base.hh 73d4798871a5 
>   src/mem/cache/base.cc 73d4798871a5 
>   src/mem/cache/cache_impl.hh 73d4798871a5 
> 
> Diff: http://reviews.gem5.org/r/2886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to