> On June 28, 2015, 5:41 p.m., Nilay Vaish wrote: > > src/mem/cache/cache_impl.hh, line 1635 > > <http://reviews.gem5.org/r/2883/diff/1/?file=46253#file46253line1635> > > > > So should we not set this block to be writeable only for notReadOnly > > caches.
I have updated the comment to make it clear why we do this. In short it is because Exclusive = Valid | Readable | Writable. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2883/#review6638 ----------------------------------------------------------- On June 10, 2015, 7:59 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2883/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 7:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10874:0c3bee36e48e > --------------------------- > mem: Allow read-only caches and check compliance > > This patch adds a parameter to the BaseCache to enable a read-only > cache, for example for the instruction cache, or table-walker cache > (not for x86). A number of checks are put in place in the code to > ensure a read-only cache does not end up with dirty data. > > A follow-on patch adds suitable read requests to allow a read-only > cache to explicitly ask for clean data. > > > Diffs > ----- > > configs/common/CacheConfig.py ebb3d0737aa7 > configs/common/Caches.py ebb3d0737aa7 > configs/common/O3_ARM_v7a.py ebb3d0737aa7 > src/mem/cache/BaseCache.py ebb3d0737aa7 > src/mem/cache/base.hh ebb3d0737aa7 > src/mem/cache/base.cc ebb3d0737aa7 > src/mem/cache/cache_impl.hh ebb3d0737aa7 > tests/configs/base_config.py ebb3d0737aa7 > tests/configs/x86_generic.py ebb3d0737aa7 > > Diff: http://reviews.gem5.org/r/2883/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
