-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2883/#review6646
-----------------------------------------------------------


I don't have a problem with this, but I'm curious for a little more detail on 
the motivation---in particular, what's the rationale for using panic_if() 
instead of assert() (or chatty_assert()) in the checks?  Do we really need to 
have these checks in even in gem5.fast?

- Steve Reinhardt


On June 29, 2015, 2:30 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2883/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 2:30 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10884:0de97ed85e6b
> ---------------------------
> mem: Allow read-only caches and check compliance
> 
> This patch adds a parameter to the BaseCache to enable a read-only
> cache, for example for the instruction cache, or table-walker cache
> (not for x86). A number of checks are put in place in the code to
> ensure a read-only cache does not end up with dirty data.
> 
> A follow-on patch adds suitable read requests to allow a read-only
> cache to explicitly ask for clean data.
> 
> 
> Diffs
> -----
> 
>   src/mem/cache/cache_impl.hh 73d4798871a5 
>   tests/configs/base_config.py 73d4798871a5 
>   tests/configs/x86_generic.py 73d4798871a5 
>   src/mem/cache/BaseCache.py 73d4798871a5 
>   src/mem/cache/base.hh 73d4798871a5 
>   src/mem/cache/base.cc 73d4798871a5 
>   configs/common/CacheConfig.py 73d4798871a5 
>   configs/common/Caches.py 73d4798871a5 
>   configs/common/O3_ARM_v7a.py 73d4798871a5 
> 
> Diff: http://reviews.gem5.org/r/2883/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to