> On July 7, 2015, 9:16 a.m., Andreas Hansson wrote: > > configs/ruby/MESI_Three_Level.py, line 103 > > <http://reviews.gem5.org/r/2776/diff/4/?file=47827#file47827line103> > > > > Why is this needed? It seems the generic version using [i] should be > > equivalent. > > > > This comment applies to all the config script changes.
This is necessary because when using the tester there is always onlyone cpu object, thus system.cpu has length 1. However, the number of ports connected to the tester piggybacks off of the -n option. This causes a mismatch between len(system.cpu) and options.num_cpus. This is the easiest options to fix this bug without a more extensive refactoring of the tester and the Ruby configs. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2776/#review6728 ----------------------------------------------------------- On July 7, 2015, 8:55 a.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2776/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 8:55 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10877:58e937f1077b > --------------------------- > ruby: cleaner ruby tester support > > This patch allows the ruby random tester to use ruby ports that may only > support instr or data requests. This patch is similar to a previous changeset > (8932:1b2c17565ac8) that was unfortunately broken by subsequent changesets. > This current patch implements the support in a more straight-forward way. > The patch also includes better DPRINTFs and generalizes the retry behavior > needed by the ruby tester so that other testers/cpu models can use it as well. > > > Diffs > ----- > > src/mem/ruby/system/Sequencer.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/example/ruby_random_test.py > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/ruby/MESI_Three_Level.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/ruby/MESI_Two_Level.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/ruby/MI_example.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/ruby/MOESI_CMP_directory.py > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/ruby/MOESI_CMP_token.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > configs/ruby/MOESI_hammer.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/Check.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/CheckTable.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/RubyTester.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/RubyTester.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/RubyTester.py > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/system/RubyPort.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/system/RubyPort.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > > Diff: http://reviews.gem5.org/r/2776/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
