> On May 28, 2015, 11:01 p.m., Brad Beckmann wrote: > > The modifications to packet queue have been removed from this patch. Can > > the rest of this patch be checked in as is? There seems to be no consensus > > on the clk domain issue. Once we check in this patch, perhaps someone who > > feels passionate on the clk domain settings for the L1 cache can fix it in > > a better way.
Thanks Brad. No objections from my side. Please go ahead. I agree with Jason that we should follow up with some RubyPort soul searching. How can we make sure it is truly just a glue-logic shim and nothing else... - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2776/#review6412 ----------------------------------------------------------- On May 26, 2015, 7:19 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2776/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 7:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10806:c2d686d64b51 > --------------------------- > ruby: cleaner ruby tester support > > This patch allows the ruby random tester to use ruby ports that may only > support instr or data requests. This patch is similar to a previous changeset > (8932:1b2c17565ac8) that was unfortunately broken by subsequent changesets. > This current patch implements the support in a more straight-forward way. > The patch also includes better DPRINTFs and generalizes the retry behavior > needed by the ruby tester so that other testers/cpu models can use it as well. > > > Diffs > ----- > > src/cpu/testers/rubytest/Check.cc df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/cpu/testers/rubytest/CheckTable.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/cpu/testers/rubytest/RubyTester.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/cpu/testers/rubytest/RubyTester.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/cpu/testers/rubytest/RubyTester.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/system/RubyPort.hh df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/system/RubyPort.cc df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/system/Sequencer.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/ruby/MOESI_hammer.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/example/ruby_random_test.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/ruby/MESI_Three_Level.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/ruby/MESI_Two_Level.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/ruby/MI_example.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/ruby/MOESI_CMP_directory.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > configs/ruby/MOESI_CMP_token.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2776/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
