----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2969/#review6765 -----------------------------------------------------------
Ship it! Thanks for cleaning these up. Below are a couple suggestions, though not absolutely necessary. src/sim/process.hh (line 182) <http://reviews.gem5.org/r/2969/#comment5856> Just a suggestion: Since we're changing these, would you mind making simFD more decriptive? Perhaps, getSimFD? src/sim/process.hh (line 192) <http://reviews.gem5.org/r/2969/#comment5857> Just a suggestion: Similar, maybe getTgtFD? - Joel Hestness On July 14, 2015, 5:31 a.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2969/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 5:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10920:4dc093946a01 > --------------------------- > style: change Process function calls to use camelCase > > The Process class methods were using an improper style and this subsequently > bled into the system call code. The following regular expressions should be > helpful if someone transitions private system call patches on top of these > changesets: > > s/alloc_fd/allocFD/ > s/sim_fd(/simFD(/ > s/sim_fd_obj/getFDEntry/ > s/fix_file_offsets/fixFileOffsets/ > s/find_file_offsets/findFileOffsets/ > > > Diffs > ----- > > src/kern/tru64/tru64.hh 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/process.hh 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/syscall_emul.cc 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/syscall_emul.hh 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/process.cc 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > > Diff: http://reviews.gem5.org/r/2969/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
