----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2969/#review6804 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On July 20, 2015, 11 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2969/ > ----------------------------------------------------------- > > (Updated July 20, 2015, 11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10920:4dc093946a01 > \-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\- > style: change Process function calls to use camelCase > > The Process class methods were using an improper style and this subsequently > bled into the system call code. The following regular expressions should be > helpful if someone transitions private system call patches on top of these > changesets: > > s/alloc_fd/allocFD/ > s/sim_fd(/getSimFD(/ > s/sim_fd_obj/getFDEntry/ > s/fix_file_offsets/fixFileOffsets/ > s/find_file_offsets/findFileOffsets/ > > > Diffs > ----- > > src/kern/tru64/tru64.hh 5fe05690d03d1e25392f9fd7e2abeb49366be9f5 > src/sim/process.hh 5fe05690d03d1e25392f9fd7e2abeb49366be9f5 > src/sim/process.cc 5fe05690d03d1e25392f9fd7e2abeb49366be9f5 > src/sim/syscall_emul.hh 5fe05690d03d1e25392f9fd7e2abeb49366be9f5 > src/sim/syscall_emul.cc 5fe05690d03d1e25392f9fd7e2abeb49366be9f5 > > Diff: http://reviews.gem5.org/r/2969/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
