> On July 2, 2015, 11:39 a.m., Jieming Yin wrote: > > We're planning to push this patch soon. Any other comments? > > Nilay Vaish wrote: > No. > > Jieming, if you wrote this and the other one related to garnet, I can > commit these two straight away.
We will commit the patches upstream ourselves. We don't want to have to deal with reordering our internal patch queue by committing patches incrementally; we will ship them all together once they're all approved. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2809/#review6692 ----------------------------------------------------------- On May 26, 2015, 1:08 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2809/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 1:08 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10842:f30297943d77 > --------------------------- > ruby: change router pipeline stages to 2 > > This patch changes the router pipeline stages from 4 to 2. The > canonical 4-stage router is conservative while a lower-latency router > with look ahead routing and speculative allocation is well acknowledged. > > > Diffs > ----- > > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2809/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
