----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/#review6861 -----------------------------------------------------------
It would be great if we can add a Param.MemoryBandwdith parameter for each direction of the link, and a basic overhead parameter for how many bytes we tack on the packet. Then we could quite easily create a throughput limiter when scheduling the next packet. src/mem/serial_link.cc (line 161) <http://reviews.gem5.org/r/2993/#comment5926> One general observation here is that this only models latency, and not throughput. Would it not make sense to also model throughput "properly"? src/mem/serial_link.cc (line 212) <http://reviews.gem5.org/r/2993/#comment5928> spacing src/mem/serial_link.cc (line 220) <http://reviews.gem5.org/r/2993/#comment5927> Same as for responses, we seem to ignore throughput here. Also, we ignore any packetisation overhead. src/mem/serial_link.cc (line 295) <http://reviews.gem5.org/r/2993/#comment5929> This should take throughput into account imho src/mem/serial_link.cc (line 336) <http://reviews.gem5.org/r/2993/#comment5930> throughput please oud - Andreas Hansson On July 29, 2015, 11:07 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2993/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 11:07 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10937:c0e250c41c52 > --------------------------- > Serial Link model for the HMC > > > Diffs > ----- > > src/mem/SConscript acd48ddd725f > src/mem/SerialLink.py PRE-CREATION > src/mem/serial_link.hh PRE-CREATION > src/mem/serial_link.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2993/diff/ > > > Testing > ------- > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
