----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/#review7179 -----------------------------------------------------------
Overall it looks great. Some very minor things (should not take many minutes), then I think we're done. Thanks again! src/mem/SerialLink.py (line 60) <http://reviews.gem5.org/r/2993/#comment6069> Could you add a comment that the bandwidth of the link is determined by the clock speed (of the comain the link is in) and the number of lanes? src/mem/serial_link.hh (line 150) <http://reviews.gem5.org/r/2993/#comment6070> Having these only for debug printouts seems a bit excessive :-) src/mem/serial_link.hh (line 255) <http://reviews.gem5.org/r/2993/#comment6071> Same as above src/mem/serial_link.hh (line 322) <http://reviews.gem5.org/r/2993/#comment6072> Only used for debug it seems src/mem/serial_link.cc (line 160) <http://reviews.gem5.org/r/2993/#comment6073> Very minor, but please stick to the style guidelines and add _space_ around operators. src/mem/serial_link.cc (line 297) <http://reviews.gem5.org/r/2993/#comment6074> A bit excessive in my opinion...is it really important to keep this debug information? - Andreas Hansson On Sept. 15, 2015, 8:46 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2993/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 8:46 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11098:6ce558162154 > --------------------------- > Serial Link model for the HMC > > > Diffs > ----- > > src/mem/SConscript efaacec43726 > src/mem/SerialLink.py PRE-CREATION > src/mem/serial_link.hh PRE-CREATION > src/mem/serial_link.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2993/diff/ > > > Testing > ------- > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
