-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2999/#review6865
-----------------------------------------------------------
so what is the difference between
xc->getCpuPtr()->wakeup(xc->threadId());
and
xc->activate();
? I think we need to clarify whether or not these are equivalent, and if so,
why we need both, and if not, what the differences are and when you should be
using one vs. the other.
src/cpu/kvm/base.hh (line 103)
<http://reviews.gem5.org/r/2999/#comment5931>
having a default value here seems a little sketchy---how many more places
are there where there's no explicity thread ID?
- Steve Reinhardt
On July 30, 2015, 11:47 a.m., Curtis Dunham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2999/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 11:47 a.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Changes wakeup functionality so that only specific threads on SMT
> capable cpus are woken.
>
>
> Diffs
> -----
>
> src/mem/abstract_mem.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/checker/cpu.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/kvm/base.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/kvm/base.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/minor/cpu.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/minor/cpu.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/o3/cpu.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/o3/cpu.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/simple/atomic.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/simple/base.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/simple/base.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/simple/timing.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/arch/x86/interrupts.cc 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/cpu/base.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/arch/arm/locked_mem.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
> src/arch/null/cpu_dummy.hh 40526b73c7db9ff2e03215cdfb477d024ea8d709
>
> Diff: http://reviews.gem5.org/r/2999/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Curtis Dunham
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
