----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3013/#review6968 -----------------------------------------------------------
Ship it! Looks good to me. Though I haven't often found use for these aggregated stats, do we have an aim or plan for adding them back? Could we use the Python stats post-processing capabilities? - Joel Hestness On Aug. 9, 2015, 6:26 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3013/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 6:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11050:8f8fc7ddc278 > --------------------------- > ruby: convert global statistical variables to local ones. > Several statistical quantities collected by ruby where recorded / published > using global variables. Since we want to have multiple ruby systems working > together, this is a hindrance. Hence, we are convert such global variables to > local ones. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractController.hh 863d314f6356 > src/mem/ruby/slicc_interface/AbstractController.cc 863d314f6356 > src/mem/slicc/symbols/StateMachine.py 863d314f6356 > > Diff: http://reviews.gem5.org/r/3013/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
