> On Sept. 9, 2015, 12:20 a.m., Nilay Vaish wrote: > > Any comments on this patch? Planning to push it in a week.
Do not push this patch. Brandon Potter has a patch that removes global variables and does so without eliminated the generated Ruby stats. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3013/#review7130 ----------------------------------------------------------- On Aug. 9, 2015, 6:26 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3013/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 6:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11050:8f8fc7ddc278 > --------------------------- > ruby: convert global statistical variables to local ones. > Several statistical quantities collected by ruby where recorded / published > using global variables. Since we want to have multiple ruby systems working > together, this is a hindrance. Hence, we are convert such global variables to > local ones. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractController.hh 863d314f6356 > src/mem/ruby/slicc_interface/AbstractController.cc 863d314f6356 > src/mem/slicc/symbols/StateMachine.py 863d314f6356 > > Diff: http://reviews.gem5.org/r/3013/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
