> On Aug. 15, 2015, 2:19 p.m., Joel Hestness wrote: > > src/mem/ruby/network/simple/PerfectSwitch.hh, line 92 > > <http://reviews.gem5.org/r/3006/diff/1/?file=48733#file48733line92> > > > > Is m_switch going to be used in a following patch? If not, can we leave > > it out for now?
Required since PerfectSwitch does not have a clock of its own. A later patch (http://reviews.gem5.org/r/2985/) that removes sender and receiver pointers from MessageBuffer means that the object owning the buffer has some way of providing timing info. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3006/#review6973 ----------------------------------------------------------- On Aug. 9, 2015, 6:24 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3006/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 6:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11033:540189ded5b8 > --------------------------- > ruby: simple network: store Switch* in PerfectSwitch and Throttle > > > Diffs > ----- > > src/mem/ruby/network/simple/PerfectSwitch.hh 863d314f6356 > src/mem/ruby/network/simple/PerfectSwitch.cc 863d314f6356 > src/mem/ruby/network/simple/Throttle.hh 863d314f6356 > src/mem/ruby/network/simple/Throttle.cc 863d314f6356 > > Diff: http://reviews.gem5.org/r/3006/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
