> On Sept. 2, 2015, 12:52 a.m., Nilay Vaish wrote: > > Does any one has any comments on this patch? > > Brad Beckmann wrote: > I don't have any problems with this patch, but I'm curious what is the > motivation?
I have updated the patch description. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3006/#review7089 ----------------------------------------------------------- On Sept. 5, 2015, 12:38 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3006/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 12:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11088:e4b173785c24 > --------------------------- > ruby: simple network: store Switch* in PerfectSwitch and Throttle > There are two reasons for doing so: > > a. provide a source of clock to PerfectSwitch. A follow on patch removes > sender > and receiver pointers from MessageBuffer means that the object owning the > buffer should have some way of providing timing info. > > b. schedule events. A follow on patch removes the consumer class. So the > PerfectSwitch needs some EventManager object to schedule events on its own. > > > Diffs > ----- > > src/mem/ruby/network/simple/PerfectSwitch.hh 0f389d88e291 > src/mem/ruby/network/simple/PerfectSwitch.cc 0f389d88e291 > src/mem/ruby/network/simple/Throttle.hh 0f389d88e291 > src/mem/ruby/network/simple/Throttle.cc 0f389d88e291 > > Diff: http://reviews.gem5.org/r/3006/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
