> On Aug. 17, 2015, 10:25 p.m., Andreas Hansson wrote: > > configs/learning_gem5/part1/caches.py, line 71 > > <http://reviews.gem5.org/r/2971/diff/1/?file=48181#file48181line71> > > > > This is a neat concept, and something that extends far beyond a simple > > education script imho. > > > > I am not discouraging the use of this idea, I just think we should not > > use it in the examples until that is "the way things are done".
I totally agree with you that this is beyond the scope of an education script, and that an education script should show "the way things are done." However, I think that something like this is *significantly* better than the current "way things are done" in the scripts. IMO, the whole configs/ directory needs a total overhaul, but I don't see that happening any time soon. Therefore, I chose to take a random step here in this new from-scratch script to see what others think. Do you have a specific suggestion to replace SimpleOpts? One thing that is very important to me for these scripts is to have precisely one place where defaults are defined. I'm open to suggestions. > On Aug. 17, 2015, 10:25 p.m., Andreas Hansson wrote: > > configs/learning_gem5/part1/two_level.py, line 1 > > <http://reviews.gem5.org/r/2971/diff/1/?file=48183#file48183line1> > > > > There is a rather unfortunate lack of re-use between the two scripts. I > > realise that they are intended to be clear and description (not short), but > > it irks me that they are so verbose. > > > > Could we use something like the base_config in the test.configs? The lack of re-use was purposeful. I meant each of these two scripts to be totally self contained. They kind of build off of one another in the text of the book, but the point I was going for is "once you finish chapter 1, look at simple.py to make sure your script matches" and "once you finish chapter 2, look at two_level.py to make sure your script matches". My purpose here isn't to make code which is useful outside the scope of the learning gem5 book. The goal is to include the learning gem5 scripts, following the book as closely as possible, so that the regression tester will catch any changes that affect the book. > On Aug. 17, 2015, 10:25 p.m., Andreas Hansson wrote: > > configs/learning_gem5/part1/two_level.py, line 72 > > <http://reviews.gem5.org/r/2971/diff/1/?file=48183#file48183line72> > > > > Odd indentation Good catch. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2971/#review6992 ----------------------------------------------------------- On July 16, 2015, 2:12 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2971/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 2:12 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10923:8f90545cd9fe > --------------------------- > config: Add configs scripts used in Learning gem5 > > Added a new directory in configs (learning_gem5) to hold the scripts that are > used in the book. See http://lowepower.com/jason/learning_gem5/ for a working > copy. For now, only the scripts in Part 1: Getting started with gem5 > have been added. A separate patch adds tests for these scripts. > > > Diffs > ----- > > configs/learning_gem5/part1/two_level.py PRE-CREATION > configs/learning_gem5/part1/simple.py PRE-CREATION > configs/common/SimpleOpts.py PRE-CREATION > configs/learning_gem5/README PRE-CREATION > configs/learning_gem5/part1/caches.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2971/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
