----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2971/#review7005 -----------------------------------------------------------
I'll second Andreas in saying thanks for the initiative to put this together. I agree that the whole config script environment needs a thorough restructuring for better modularity and flexibility. I also understand, based on your responses to Andreas, that that's not your goal here, and that comes out when reading your tutorial. I think the one thing that would be really valuable would be extend the README here to make that goal more explicit, adding in disclaimers etc. about how these scripts are for educational purposes only, not intended to be used outside the scope of the tutorial, etc.---basically encapsulating the caveats from your responses to Andreas to clarify things for people that stumble on these directly and don't come looking for them after reading the tutorial. - Steve Reinhardt On Aug. 18, 2015, 8:18 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2971/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 8:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10923:8f90545cd9fe > --------------------------- > config: Add configs scripts used in Learning gem5 > > Added a new directory in configs (learning_gem5) to hold the scripts that are > used in the book. See http://lowepower.com/jason/learning_gem5/ for a working > copy. For now, only the scripts in Part 1: Getting started with gem5 > have been added. A separate patch adds tests for these scripts. > > > Diffs > ----- > > configs/common/SimpleOpts.py PRE-CREATION > configs/learning_gem5/README PRE-CREATION > configs/learning_gem5/part1/caches.py PRE-CREATION > configs/learning_gem5/part1/simple.py PRE-CREATION > configs/learning_gem5/part1/two_level.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2971/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
