----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3056/#review7045 -----------------------------------------------------------
Ship it! Ship It! - Jason Power On Aug. 19, 2015, 2:43 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3056/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 2:43 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11052:3f0470977de4 > --------------------------- > sim: Remove autoserialize support for exit events > > This changeset removes the support for the autoserialize parameter in > GlobalSimLoopExitEvent (including exitSimLoop()) and > LocalSimLoopExitEvent. > > Auto-serialization of the LocalSimLoopExitEvent was never used, so > this is not expected to affect anything. However, it was sometimes > used for GlobalSimLoopExitEvent. Unfortunately, serialization of > global events has never been supported, so checkpoints with such > events will currently cause simulation panics. > > The serialize parameter to exitSimLoop() has been left in-place to > maintain API compatibility (removing it would affect m5ops). Instead > of just dropping it, we now print a warning if the parameter is set > and the exit event is scheduled in the future (i.e., not at the > current tick). > > > Diffs > ----- > > src/sim/sim_events.hh 110cce93d398 > src/sim/sim_events.cc 110cce93d398 > > Diff: http://reviews.gem5.org/r/3056/diff/ > > > Testing > ------- > > Regressions pass. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
