Hi Andreas, Yes, I agree that committers should run full regressions (i.e. all quick tests that are verified daily on Zizzer, right?). I ran quick regressions that are configured correctly, and they pass with this patch.
The problem with running all quick regressions currently is that many tests don't run out-of-the-box, and I haven't found instructions on how to set up tests like the cpu2000 and FS tests. I made a request for such information in this thread, though I haven't yet seen response: https://www.mail-archive.com/[email protected]/msg16328.html I'm totally willing to run all the quick regressions and update as appropriate, but I'd like more information on these. How does one set up FS and cpu2000 tests? Can we include Linux binaries in the tests/ directory so those tests can run out-of-the-box? Can we change the cpu2000 tests to some other benchmarks without distribution restrictions, so they too can be included in tests/? Thanks, Joel On Thu, Aug 27, 2015 at 7:19 AM, Andreas Hansson <[email protected]> wrote: > Hi Joel, > > It seems the patch from Emilio changes a few of the full system > regressions. I merely wanted to check if you simply forgot to push a stats > update? > > In general I would expect anyone pushing patches to do a full regression > run (and sanity check any changes). Agreed? > > Thanks, > > Andreas > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 > ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2548782 > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > -- Joel Hestness PhD Candidate, Computer Architecture Dept. of Computer Science, University of Wisconsin - Madison http://pages.cs.wisc.edu/~hestness/ _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
