> On Sept. 9, 2015, 6:42 p.m., Jason Lowe-Power wrote: > > src/mem/ruby/network/simple/PerfectSwitch.cc, line 146 > > <http://reviews.gem5.org/r/3079/diff/1/?file=49160#file49160line146> > > > > Do you foresee this function being used outside of the "operateVnet" > > function? If not, I don't understand the need for this change. > > Nilay Vaish wrote: > We will be removing the operateMessageBuffer() function altogether in a > later patch. > Take look at: reviews.gem5.org/r/2987 > > Jason Lowe-Power wrote: > Ah, I didn't catch that one. I guess I'm OK with this patch, but only > when the other is submitted.
I have updated the description for the patch. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3079/#review7135 ----------------------------------------------------------- On Sept. 9, 2015, 7:25 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3079/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 7:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11069:e83d2f2cbb57 > --------------------------- > ruby: perfect switch: refactor code > Refactored the code in operateVnet(), moved partly to a new function > operateMessageBuffer(). This is required since a later patch moves to having a > wakeup event per MessageBuffer instead of one event for the entire Switch. > > > Diffs > ----- > > src/mem/ruby/network/simple/PerfectSwitch.hh 969113566d50 > src/mem/ruby/network/simple/PerfectSwitch.cc 969113566d50 > > Diff: http://reviews.gem5.org/r/3079/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
