----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3079/#review7156 -----------------------------------------------------------
Ship it! Splitting these functions up is generally a good thing. There shouldn't be many conflicts with this patch. - Brad Beckmann On Sept. 9, 2015, 7:25 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3079/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 7:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11069:e83d2f2cbb57 > --------------------------- > ruby: perfect switch: refactor code > Refactored the code in operateVnet(), moved partly to a new function > operateMessageBuffer(). This is required since a later patch moves to having a > wakeup event per MessageBuffer instead of one event for the entire Switch. > > > Diffs > ----- > > src/mem/ruby/network/simple/PerfectSwitch.hh 969113566d50 > src/mem/ruby/network/simple/PerfectSwitch.cc 969113566d50 > > Diff: http://reviews.gem5.org/r/3079/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
