----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3101/#review7144 -----------------------------------------------------------
util/systemc/main.cc (line 285) <http://reviews.gem5.org/r/3101/#comment6038> I'm pretty sure this won't work as expected since global stuff (curTick, version tags, etc) aren't unserialized as far as I can tell. You'll most likely trigger an assertion at some point as well since the state of the drain state of the system won't be correct when resuming (it'll be in the Running state when instantiating things). You currently need to call DrainManager::preCheckpointRestore() before restoring from the checkpoint to force the system into the right state. The right solution to this is probably to unify the checkpoint restore code and move most of it from simulate.py to a static Serializable::unserializeAll() method (similar to how we do serialization) that is used both by the C++ manager and the Python code. As you already mentioned, restoring from a checkpoint probably doesn't work. Looks good other than that. I'm Ok with this change if you add a warning when restoring from checkpoints, but please fix checkpointing in a separate commit in that case. - Andreas Sandberg On Sept. 9, 2015, 11:03 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3101/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 11:03 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Due to changes in Drain Manager, the lastest systemc coupling doesn't work. > The code for handling Checkpoint has been modified and it is now compatiable > with new drain manager. > > > Diffs > ----- > > util/systemc/main.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/3101/diff/ > > > Testing > ------- > > Testing is being done on systemC coupling. It needs more testing to verify > checkpointing feature. > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
