On Sept. 10, 2015, 4:20 p.m., Abdul Mutaal Ahmad wrote: > > As you already mentioned, restoring from a checkpoint probably doesn't > > work. Looks good other than that. I'm Ok with this change if you add a > > warning when restoring from checkpoints, but please fix checkpointing in a > > separate commit in that case. > > Andrew Bardsley wrote: > Andreas' suggestions seems to work for the C++ config example (I've been > freshening it too, expect a patch soon). I inserted: > > DrainManager::instance().preCheckpointRestore(); > > Before checkpoint restoring and that seemed to work.
Abdul, we pushed a fix a few weeks ago. Can you double check if any of the functionality in this patch is still needed, and if so re-post? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3101/#review7144 ----------------------------------------------------------- On Sept. 9, 2015, 10:03 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3101/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 10:03 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Due to changes in Drain Manager, the lastest systemc coupling doesn't work. > The code for handling Checkpoint has been modified and it is now compatiable > with new drain manager. > > > Diffs > ----- > > util/systemc/main.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/3101/diff/ > > > Testing > ------- > > Testing is being done on systemC coupling. It needs more testing to verify > checkpointing feature. > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
