----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3111/#review7171 -----------------------------------------------------------
Tony, expand the review description and add the problem that you are facing. src/mem/ruby/network/Network.hh (line 75) <http://reviews.gem5.org/r/3111/#comment6040> These functions need not be virtual now. src/mem/slicc/symbols/StateMachine.py (line 299) <http://reviews.gem5.org/r/3111/#comment6042> Why do we need virtual here? - Nilay Vaish On Sept. 14, 2015, 3:22 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3111/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 3:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11095:55e87e005a11 > --------------------------- > ruby: fix message buffer init order > > > Diffs > ----- > > src/mem/ruby/network/Network.hh 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/Network.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/simple/SimpleNetwork.hh > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/ruby/network/simple/SimpleNetwork.cc > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > src/mem/slicc/symbols/StateMachine.py > 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd > > Diff: http://reviews.gem5.org/r/3111/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
