----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3111/ -----------------------------------------------------------
(Updated Sept. 14, 2015, 10:37 a.m.) Review request for Default. Repository: gem5 Description (updated) ------- Changeset 11095:d1f176c26916 --------------------------- ruby: fix message buffer init order The recent changes to make MessageBuffers SimObjects required them to be initialized in a particular order, which could break some protocols. Fix this by calling initNetQueues on the external nodes of each external link in the constructor of Network. This patch also refactors the duplicated code for checking network allocation and setting net queues (which are called by initNetQueues) from the simple and garnet networks to be in Network. Diffs (updated) ----- src/mem/ruby/network/Network.hh 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/Network.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/simple/SimpleNetwork.hh 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/ruby/network/simple/SimpleNetwork.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/slicc/symbols/StateMachine.py 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd Diff: http://reviews.gem5.org/r/3111/diff/ Testing ------- Thanks, Tony Gutierrez _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
